CENG-260: update-cloudsmith-cli-to-include-zipapp-in-the-release #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddycarey
reviewed
Jun 11, 2024
| @@ -0,0 +1,49 @@ | |||
| name: Create Zipapp and Release | |||
There was a problem hiding this comment.
Should we do this in CircleCI since that's where the rest of the CI for this repo already runs?
There was a problem hiding this comment.
I'm not that familiar with CircleCi so decided to do it in GHA instead. I did briefly take a look at it but GHA has a nicer and easier way of implementing this as part of their built-in action and uses pre-defined credentials. If this is a biggie, I can take a look at it but if you're happy to roll with this and I can take a proper look at this when I get some more time.
paddycarey
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.pyzfile