-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eng-2261): License policy CLI #113
Conversation
Looks good at first glance. I think I confused you earlier with the whole license/licence discussion. We should adhere to "International English" in anything user-facing like commands and output. Maybe it would be better to switch back to using "license" everywhere to avoid confusion, and if you have any cases where a variable named "license" shadows the builtin, then you could just append an underscore to the variable name i.e. license_ |
The only place |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a handful of tiny nitpicks. Approved in advance.
Code Climate has analyzed commit b315a2a and detected 15 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 96.2% (50% is the threshold). This pull request will bring the total coverage in the repository to 56.9% (1.6% change). View more on Code Climate. |
Adds functionality to manage license policies via CLI