Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eng-2261): License policy CLI #113

Merged
merged 8 commits into from
May 11, 2023
Merged

Conversation

Leeoc
Copy link
Contributor

@Leeoc Leeoc commented May 10, 2023

Adds functionality to manage license policies via CLI

image

@Leeoc Leeoc marked this pull request as ready for review May 10, 2023 15:43
@chrisimcevoy
Copy link
Collaborator

Looks good at first glance. I think I confused you earlier with the whole license/licence discussion. We should adhere to "International English" in anything user-facing like commands and output. Maybe it would be better to switch back to using "license" everywhere to avoid confusion, and if you have any cases where a variable named "license" shadows the builtin, then you could just append an underscore to the variable name i.e. license_

@Leeoc
Copy link
Contributor Author

Leeoc commented May 11, 2023

Looks good at first glance. I think I confused you earlier with the whole license/licence discussion. We should adhere to "International English" in anything user-facing like commands and output. Maybe it would be better to switch back to using "license" everywhere to avoid confusion, and if you have any cases where a variable named "license" shadows the builtin, then you could just append an underscore to the variable name i.e. license_

The only place license was an issue was for creating the base AliasGroup, just realised I can set the group to license and have the function def as licence to avoid the builtin... :noob:

Copy link
Collaborator

@chrisimcevoy chrisimcevoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a handful of tiny nitpicks. Approved in advance.

@codeclimate
Copy link

codeclimate bot commented May 11, 2023

Code Climate has analyzed commit b315a2a and detected 15 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3
Duplication 12

The test coverage on the diff in this pull request is 96.2% (50% is the threshold).

This pull request will bring the total coverage in the repository to 56.9% (1.6% change).

View more on Code Climate.

@Leeoc Leeoc merged commit 28f5e3c into master May 11, 2023
@Leeoc Leeoc deleted the eng-2261/license-policy-cli branch May 11, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants