Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecate npm_package argument #39

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

just-boris
Copy link
Member

Following cloudscape-design/actions#5 we can now cleanup the unused argument.

First, we mark it here as optional, then remove from the main workflow and then doing the final cleanup here.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@just-boris just-boris requested a review from a team as a code owner December 15, 2023 21:30
@just-boris just-boris requested review from michaeldowseza and removed request for a team December 15, 2023 21:30
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb9680f) 92.00% compared to head (3b8914e) 92.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   92.00%   92.00%           
=======================================
  Files           1        1           
  Lines          25       25           
  Branches        9        9           
=======================================
  Hits           23       23           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@just-boris just-boris merged commit 0b57fb3 into main Dec 18, 2023
26 checks passed
@just-boris just-boris deleted the release-notes-workflow branch December 18, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants