feat: Month granularity for date-range-picker #3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3077 +/- ##
==========================================
+ Coverage 96.45% 96.47% +0.01%
==========================================
Files 790 791 +1
Lines 22294 22534 +240
Branches 7667 7793 +126
==========================================
+ Hits 21504 21739 +235
- Misses 738 743 +5
Partials 52 52 ☔ View full report in Codecov by Sentry. |
dpitcock
force-pushed
the
denpitco-monthly-range-picker2
branch
from
7491fa5 to
7f28657
Compare
dpitcock
force-pushed
the
denpitco-monthly-range-picker2
branch
3 times, most recently
from
e8bd8f5 to
f61d398
Compare
dpitcock
force-pushed
the
denpitco-monthly-range-picker2
branch
from
f61d398 to
74458ef
Compare
dpitcock
force-pushed
the
denpitco-monthly-range-picker2
branch
from
74458ef to
73641df
Compare
dpitcock
force-pushed
the
denpitco-monthly-range-picker2
branch
from
d63e7be to
24aba24
Compare
dpitcock
force-pushed
the
denpitco-monthly-range-picker2
branch
from
24aba24 to
0773794
Compare
dpitcock
commented
Dec 11, 2024
dpitcock
force-pushed
the
denpitco-monthly-range-picker2
branch
from
fe270dc to
91cd9c3
Compare
just-boris
reviewed
Jan 31, 2025
Comment on lines
+12
to
+13
| import startOfYear from 'date-fns/startOfYear'; | ||
| import sub from 'date-fns/sub'; |
There was a problem hiding this comment.
related to this PR: #3240
it will probably break after another rebase
just-boris
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Month granularity for date-range-picker
The Date Picker component has a granularity prop that can be set to "month" which disallows the selection of day and allows the selection of month. This functionality is now being extended onto Date Range Picker component, so it will also support month range selection
issues: [AWSUI-18630, AWSUI-20124, AWSUI-8139]
Previous PRs for this project
How has this been tested?
test coverage expanded to include both unit tests and integration tests for the DateRangePicker component utilizing the 'month' granularity setting. These tests now encompass rendered iterations of the components, ensuring comprehensive validation of this specific functionality.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.