Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Progressbar handling #336

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix: Progressbar handling #336

merged 1 commit into from
Jun 6, 2024

Conversation

disq
Copy link
Member

@disq disq commented Jun 6, 2024

Adds option to skip using progressbar. Since the new progressbar release, writing to the progressbar where the target writer is closed (in our case, os.Stdout) produces an error.

@disq disq requested a review from a team as a code owner June 6, 2024 08:46
@disq disq requested review from marianogappa and removed request for a team June 6, 2024 08:46
@github-actions github-actions bot added the fix label Jun 6, 2024
@disq disq changed the title fix: Progressbar handling fix!: Progressbar handling Jun 6, 2024
@disq disq mentioned this pull request Jun 6, 2024
Merged
@disq disq requested a review from erezrokah June 6, 2024 08:49
@disq disq mentioned this pull request Jun 6, 2024
Closed
2 tasks
@erezrokah erezrokah changed the title fix!: Progressbar handling fix: Progressbar handling Jun 6, 2024
erezrokah
erezrokah approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think we can skip the major bump. Don't think anything else is using this API other than the CLI, and if we do an major bump we need to update all improves and the version in go.mod

@disq disq merged commit 538487d into main Jun 6, 2024
12 checks passed
@disq disq deleted the fix/progressbar-handling branch June 6, 2024 09:11
@cq-bot cq-bot mentioned this pull request Jun 6, 2024
Merged
kodiakhq bot pushed a commit that referenced this pull request Jun 6, 2024
@cq-bot
chore(main): Release v1.19.19 (#337)
7ec2a06 
🤖 I have created a release *beep* *boop*
---


## [1.19.19](v1.19.18...v1.19.19) (2024-06-06)


### Bug Fixes

* Progressbar handling ([#336](#336)) ([538487d](538487d))
* Revert "fix(deps): Update module github.com/schollz/progressbar/v3 to v3.14.3 ([#330](#330))" ([#338](#338)) ([74429d5](74429d5))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot pushed a commit to cloudquery/cloudquery that referenced this pull request Jun 6, 2024
@disq
fix: Progressbar related error when log-console option is used (#18161
bbac469 
)

Goes with cloudquery/plugin-pb-go#336

~needs cloudquery/plugin-pb-go#337 released~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erezrokah erezrokah erezrokah approved these changes

@candiduslynx candiduslynx candiduslynx approved these changes

@marianogappa marianogappa Awaiting requested review from marianogappa marianogappa is a code owner automatically assigned from cloudquery/cloudquery-framework

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@disq @candiduslynx @erezrokah