Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Remove non standard List/Detail implementations #1237

Merged
merged 9 commits into from
Jul 22, 2022
Merged

feat: Remove non standard List/Detail implementations #1237

merged 9 commits into from
Jul 22, 2022

Conversation

bbernays
Copy link
Contributor

Summary

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@bbernays bbernays requested a review from a team as a code owner July 18, 2022 20:22
@bbernays bbernays requested review from spangenberg and roneli and removed request for a team July 18, 2022 20:22
disq
disq approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@disq disq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would remove the comment in athena fetch resolver

roneli
roneli approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had one nit, I think an unused line.

resources/services/sagemaker/training_jobs.go Outdated Show resolved Hide resolved
@bbernays bbernays merged commit 004a544 into cloudquery:main Jul 22, 2022
@cq-bot cq-bot mentioned this pull request Jul 22, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roneli roneli roneli approved these changes

@yevgenypats yevgenypats yevgenypats approved these changes

@disq disq disq approved these changes

@spangenberg spangenberg Awaiting requested review from spangenberg spangenberg is a code owner automatically assigned from cloudquery/cloudquery-opensource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bbernays @disq @yevgenypats @roneli