Update to new null-label. Add stack sub-module to calculate stack names
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test all |
|
/test all |
osterman
previously approved these changes
Aug 21, 2021
* Custom context.tf for stack * Make custom context.tf module name "always" * Add context-always to remote-state, remove workspace from config * Auto Format Co-authored-by: cloudpossebot <[email protected]>
|
/test all |
|
/test all |
osterman
approved these changes
Aug 23, 2021
Nuru
approved these changes
Aug 23, 2021
3 tasks
korenyoni
approved these changes
Aug 23, 2021
There was a problem hiding this comment.
Looks good to me.
One thing I will say is I think context-always should be exported from null_label and automated via the auto-context workflow, but perhaps renamed to context-stack-config so that it isn't accidentally used anywhere else. Either way, that's not really relevant to this PR and can be done later if anyone shares my opinion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
null-labelstacksub-module to calculate stack nameswhy
Use new features from
null-labelmodule:idcomponent:tenantlabels_as_tagscontrols which labels are exported as tagsdescriptor_formatsgenerates new outputdescriptors- use it to calculate the stack namesstacksubmodule is used to calculate stack names in one place and use the same logic in all other sub-modulesreferences