Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to TF 0.12. Add tests. Add Codefresh test pipeline #16

Merged
merged 10 commits into from
May 1, 2020
Merged

Convert to TF 0.12. Add tests. Add Codefresh test pipeline #16

merged 10 commits into from
May 1, 2020

Conversation

maximmi
Copy link
Contributor

@maximmi maximmi commented Apr 22, 2020

what

  • Port module to Terraform 0.12
  • Pin all providers
  • Add example for testing
  • Add bats and terratest for the example
  • Add Codefresh badge to point to the test pipeline in terraform-modules project
  • Update README

why

  • Module currently does not work with 0.12. Much easier syntax
  • Better regression control
  • Automatically test the example on every commit and pull request
  • Provision resources on AWS in the test account and check the outputs for the correct values
  • terraform-modules project contains pipelines for all terraform modules

related

Dallas Slaughter added 2 commits February 6, 2020 14:55
[improvement] - Upgrade to 0.12 syntax, fix bool vars.
b77d50b 
Some vars used "true" instead of bool true, changed those and added type.
Updated terraform-null-label from 0.3.3 to 0.16.0 (latest at time of commit).
[improvement] - Replace local.enabled with var.enabled
67b19aa
@maximmi maximmi requested review from osterman and aknysh April 22, 2020 22:53
@maximmi
Copy link
Contributor Author

maximmi commented Apr 23, 2020

/codefresh run test

1 similar comment
@maximmi
Copy link
Contributor Author

maximmi commented Apr 23, 2020

/codefresh run test

johncblandii
johncblandii requested changes Apr 28, 2020
View reviewed changes
Copy link

@johncblandii johncblandii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor notes on filenames not matching the noted regions, but overall it looks solid.

examples/complete/fixtures.us-west-1.tfvars Outdated Show resolved Hide resolved
examples/vpc-only/fixtures.us-west-1.tfvars Outdated Show resolved Hide resolved
@maximmi maximmi merged commit 7b3176f into master May 1, 2020
@maximmi maximmi deleted the terraform-0.12 branch May 1, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johncblandii johncblandii johncblandii approved these changes

@osterman osterman Awaiting requested review from osterman

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximmi @johncblandii