Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AWS provider 4.40 deprecation warnings #35

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Fix AWS provider 4.40 deprecation warnings #35

merged 1 commit into from
Mar 13, 2023

Conversation

simonweil
Copy link
Contributor

@simonweil simonweil commented Dec 20, 2022 •
edited
Loading

@simonweil simonweil requested review from a team as code owners December 20, 2022 11:57
@purduemike
Copy link

Can someone approve this PR?

aknysh
aknysh requested changes Jan 24, 2023
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonweil please see comments in #33 (review)

thanks for the PRs

@simonweil simonweil force-pushed the fix-deprecation-warnings branch from 9827caf to 69e7761 Compare March 9, 2023 12:07
@simonweil
Copy link
Contributor Author

@aknysh PR updated with the last changes to master, it's ready for merge from my point of view.
Let's go? :)

@aknysh aknysh added the major Breaking changes (or first stable release) label Mar 13, 2023
@aknysh
Copy link
Member

aknysh commented Mar 13, 2023

/test all

@aknysh aknysh merged commit 9489339 into cloudposse:master Mar 13, 2023
@simonweil
Copy link
Contributor Author

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@r351574nc3 r351574nc3 Awaiting requested review from r351574nc3 r351574nc3 was automatically assigned from cloudposse/contributors

@srhopkins srhopkins Awaiting requested review from srhopkins srhopkins was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
major Breaking changes (or first stable release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix deprecation with aws_identitystore_group data source with AWS provider 4
3 participants
@simonweil @purduemike @aknysh