Add cloudwatch logging options for runCommand patch manager tasks #48
Conversation
|
/terratest |
1 similar comment
|
/terratest |
|
I was not able to update the readme as the |
@gpapakyriakopoulos thanks for your contribution! The issue with README generation will be fixed today, I'll re-run tests when it's done. |
|
/terratest |
|
@gpapakyriakopoulos could you please run again the following commands locally? I believe this should work now 👍 |
|
Thanks @gpapakyriakopoulos for creating this pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while. While you wait, make sure to review our contributor guidelines. Tip Need help or want to ask for a PR review to be expedited?Join us on Slack in the |
Seemed to worked correctly this time! I've added the README update in the PR, thanks! |
|
/terratest |
|
@gpapakyriakopoulos mind syncing your fork with the base branch? |
Based on AWS documentation [1] runCommand executions support directly logging to cloudwatch instead of an S3 bucket. To that end we introduce 3 extra module variables, the first 2 (`cloudwatch_log_output_enabled` & `cloudwatch_log_group_name`) to configure whether cloudwatch logging is enabled and whether a custom cloudwatch log group name should be provided (if not a default is created, see [2]). The 3rd variable (`s3_log_output_enabled`) is introduced to optionally disable supplying an S3 bucket for logging, since cloudwatch logging should be enough for some use cases. [1] https://docs.aws.amazon.com/systems-manager/latest/userguide/sysman-rc-setting-up-cwlogs.html [2] https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ssm_maintenance_window_task#cloudwatch_log_group_name
Head branch was pushed to by a user without write access
mergify
bot
dismissed
gberenice’s stale review
This Pull Request has been updated, so we're dismissing all reviews.
|
Just rebased using the GitHub button @gberenice. Seems like you need to run terratest again + add your review again. |
|
/terratest |
|
A new version v1.0.1 was released. Thanks @gpapakyriakopoulos ! |
Based on AWS documentation [1] runCommand executions support directly logging to cloudwatch instead of an S3 bucket.
To that end we introduce 3 extra module variables, the first 2 (
cloudwatch_log_output_enabled&cloudwatch_log_group_name) to configure whether cloudwatch logging is enabled and whether a custom cloudwatch log group name should be provided (if not a default is created, see [2]). The 3rd variable (s3_log_output_enabled) is introduced to optionally disable supplying an S3 bucket for logging, since cloudwatch logging should be enough for some use cases.[1] https://docs.aws.amazon.com/systems-manager/latest/userguide/sysman-rc-setting-up-cwlogs.html
[2] https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ssm_maintenance_window_task#cloudwatch_log_group_name