fix!: various issues / cleanup + adds approve_until_date support

[Gowiem]

what

• Converts bucket_id variable to list(string)
• Removes region variable
• Cleans up some potential enabled = false issues in outputs.tf they were dependent on resources existing
• Fixes typo in scan logs bucket prefix
• Adds s3_bucket_prefix_scan_logs variable
• Adds approve_until_date support to patch_baseline_approval_rules variable

why

• Count resolution error when providing a bucket_id #41 shows that passing in a bucket_id results in a known issue: The "count" value depends on resource attributes that cannot be determined until apply hashicorp/terraform#28962. We've seen this internally before and our suggested pattern is to switch to list(string) as the type and check the length.
  • (BREAKING CHANGE)
• Features
  • Adds support for passing a custom prefix for scan logs.
  • Adds support the ability to patch on a timeline via approve_until_date
• General cleanup of issues that I saw for this module:
  • region variable not used, so needed to be removed (BREAKING CHANGE)
  • Bumps s3-module to latest
  • Typo
  • Updates example to an actual use-case where patching would occur
  • Removes an unnecessary label
  • Avoids issues with outputs not working in the case that a user passed enabled = false since outputs were dependent on resources being at position 0 via list access.

references

• Closes Count resolution error when providing a bucket_id #41
• Closes Minor typo on S3 bucket key prefix #39
• Closes approve_after_days option is not available on approval_rule  #8
• Closes Complete example Target Tagging is wrong #40
• Closes output_s3_key_prefix variable for scan logs #14

[Gowiem]

/terratest

[Gowiem]

/terratest

[aknysh]

LGTM, thanks @Gowiem

[jamengual]

LGTM