Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(ssm_log_bucket): use source_policy_documents #22

Merged
merged 4 commits into from
Dec 13, 2022
Merged

update(ssm_log_bucket): use source_policy_documents #22

merged 4 commits into from
Dec 13, 2022

Conversation

mikedizon
Copy link
Contributor

@mikedizon mikedizon commented Dec 13, 2022 •
edited
Loading

what

  • using source_policy_documents for bucket policy

why

  • bucket was created, but no policy was applied

references

@mikedizon mikedizon requested review from a team as code owners December 13, 2022 15:20
@mikedizon mikedizon requested review from dotCipher and RothAndrew and removed request for a team December 13, 2022 15:20
@aknysh
Copy link
Member

aknysh commented Dec 13, 2022

/test all

@aknysh
Copy link
Member

aknysh commented Dec 13, 2022

test/terratest is failing, prob the AMI does not exist or some other issue with it https://github.com/cloudposse/terraform-aws-ssm-patch-manager/blob/master/examples/complete/main.tf#L31

aknysh
aknysh reviewed Dec 13, 2022
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikedizon thanks for the PR.
The test is failing, can you please take a look at it?

@mikedizon
Copy link
Contributor Author

/test all

1 similar comment
@aknysh
Copy link
Member

aknysh commented Dec 13, 2022

/test all

@aknysh
Copy link
Member

aknysh commented Dec 13, 2022

/test all

@aknysh aknysh added the patch A minor, backward compatible change label Dec 13, 2022
aknysh
aknysh approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mikedizon

@aknysh aknysh merged commit 627eeb6 into cloudposse:master Dec 13, 2022
hessamalipour pushed a commit to hessamalipour/terraform-aws-ssm-patch-manager that referenced this pull request Jan 3, 2023
@mikedizon @cloudpossebot
update(ssm_log_bucket): use source_policy_documents (cloudposse#22)
b738cdd 
* update(ssm_log_bucket): use source_policy_documents

* Auto Format

* update(main.tf): updated ami reference

* update(main.tf): use an ami from us-east-2

Co-authored-by: cloudpossebot <[email protected]>
@Gowiem Gowiem mentioned this pull request Feb 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher was automatically assigned from cloudposse/contributors

@RothAndrew RothAndrew Awaiting requested review from RothAndrew RothAndrew was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikedizon @aknysh @cloudpossebot