Terraform Provider v5 Support

[milldr]

This may be the final PR for this module. This module offers no value beyond the s3-bucket module and the terraform-aws-route53-alias module, so Cloud Posse is phasing out support for this redundant module. However, this PR should leave this module in a workable state until archival.

what

• Terraform v5 updates
• Support for new S3 bucket requirements
• Rebuilt .github config
• Apply tflint requirements

make init
make github/init
make readme

why

• Updates to requirements for CI checks
• Set bucket ownership and grants instead of public-read ACL to satisfy new S3 requirements

references

Closes Related PRs

• closes Update README.md and docs #92
• closes Support AWS Provider V5 #91
• closes Update Terraform aws to v5 (main) #89
• closes Changed ACL #88
• closes Update Terraform aws to v4 (main) - abandoned #86
• closes Update Terraform cloudposse/s3-log-storage/aws to v1 - abandoned #82
• closes Upgrade packages to support AWS v4 #80
• closes S3 resource supports AWS provider v4  #77
• closes Update Terraform cloudposse/s3-log-storage/aws to v0.28.0 - abandoned #62

Closes Related Issues

• closes Upgrade to AWS provider 4.x #87
• closes Changes to default S3 settings cause module to fail #84
• closes Failed to query available provider packages when using AWS provider 4.48.0 #83
• closes Support AWS Provider v4, Support latest context.tf #75
• closes Terraform version 0.12 to 13 upgrade issue #72
• closes Dependency Dashboard #70

[bridgecrew]

Bridgecrew has found errors in this PR ⬇️

[milldr]

/terratest

[milldr]

/terratest

[milldr]

/terratest

[milldr]

/terratest

[Nuru]

Convert to pass-through to terraform-aws-s3-bucket so we can archive this module. s3-bucket should already have all the necessary features, and if not, add them there. LMK if it is too much work.

Update: it is, in fact, too much work.

[milldr]

Convert to pass-through to terraform-aws-s3-bucket so we can archive this module. s3-bucket should already have all the necessary features, and if not, add them there. LMK if it is too much work.

We decided that we will leave this as a final PR for the module, and redirect users to use the s3-bucket module instead. See the README and linked module in this PR description

[milldr]

/terratest

[milldr]

Labeled as a major release to call attention to final PR

[Nuru]

/terratest