Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance lifecycle object with optionals, limit length of bucket name #87

Merged
merged 1 commit into from
May 8, 2023
Merged

Enhance lifecycle object with optionals, limit length of bucket name #87

merged 1 commit into from
May 8, 2023

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented May 7, 2023

what

  • Limit length of auto-generated bucket name to match AWS-imposed limit
  • Enhance lifecycle_configuration_rules to be fully defined with optional members

why

  • Avoid situation where module fails because auto-generated bucket name is too long
  • Make it easier to build a list of rules

references

@Nuru Nuru added enhancement New feature or request minor New features that do not break anything labels May 7, 2023
@Nuru Nuru requested review from a team as code owners May 7, 2023 21:33
@Nuru Nuru requested review from dotCipher and joe-niland May 7, 2023 21:33
@Nuru
Copy link
Contributor Author

Nuru commented May 7, 2023

/test all

@Nuru Nuru requested review from osterman, max-lobur and aknysh May 7, 2023 21:51
@Nuru Nuru enabled auto-merge (squash) May 7, 2023 21:52
@Nuru Nuru merged commit 68c18f4 into master May 8, 2023
@Nuru Nuru deleted the bucket-length branch May 8, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher was automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland was automatically assigned from cloudposse/contributors

@osterman osterman Awaiting requested review from osterman

@max-lobur max-lobur Awaiting requested review from max-lobur

Assignees
No one assigned
Labels
enhancement New feature or request minor New features that do not break anything
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nuru @aknysh