Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Terraform cloudposse/s3-bucket/aws to v0.48.0 #67

Closed
wants to merge 2 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 23, 2022

WhiteSource Renovate

This PR contains the following updates:

Package Type Update Change
cloudposse/s3-bucket/aws (source) module minor 0.47.0 -> 0.48.0

Release Notes

cloudposse/terraform-aws-s3-bucket

v0.48.0

Compare Source

This release is an early release in order to unblock people who are blocked because v0.47.0 does not work with AWS Provider v4. However, the newly introduced lifecycle_configuration_rules will be replaced in the next release with a more flexible (and completely incompatible) structure that supports the evolving variety of storage options AWS provides. For this reason, we recommend users continue to use the Deprecated lifecycle_rules input for now, and anticipate it will be supported for a considerable length of time going forward.

See Upgrading to v0.48.0 and AWS provider version 4.x for details about actions you will need to take when updating to this version.

🚀 Enhancements

Upgrade to v4 aws provider @​nitrocode (#​131) #### what * [x] Upgrade to v4 aws provider * Deprecated `policy` in favor of `source_policy_documents`, closes #​124 * Deprecated `grants` in favor of `acl_grants` * Deprecated `lifecycle_rules` in favor of `lifecycle_configuration_rules` * [x] All tests pass * [x] Current tests pass * [ ] Tests do not check website inputs. The `website_inputs` is unavailable in the tests. * [ ] Tests do not check cors. The `cors_rule_inputs` is available but unused. * [x] Backwards compatible - Is it possible to make it backwards compatible ? * [x] Generate the lifecycle rule ids ? * [x] Translate the `grant.permissions` into separate `grant.permission` blocks ? * Migration document in [this repo's Wiki](https://togithub.com/cloudposse/terraform-aws-s3-bucket/wiki/Upgrading-to-v0.48.0-and-AWS-provider-version-4.x) #### why * Current version incompatible with AWS provider v4.x
│ Error: Unsupported attribute
│ 
│   on .terraform-mdev/modules/s3_bucket/main.tf line 166, in resource "aws_s3_bucket" "default":
│  166:         for_each = local.s3_replication_rules == null ? [] : local.s3_replication_rules
│ 
│ This object does not have an attribute named "s3_replication_rules".
  • One upgraded to version 4.x, module no longer works with AWS provider 3.x
  • Pin to >= 4.2.0 because of relevant bug fixes needed by this module

references

notes

  • grants is now deprecated, but still supported. New input replacing it is acl_grants. The only difference is that grants takes a list of permissions and acl_grants takes a single permission. The only reason we are making grants deprecated is so that our inputs track the AWS resource inputs.
  • lifecycle_rules is now deprecated but still supported, replaced with lifecycle_configuration_rules, which is identical except that lifecycle_configuration_rules has an id for each rule, which is now required by the AWS resource (doc). This module supplies an id for lifecycle_rules.
  • aws_s3_bucket_lifecycle_configuration requires a static rules.filter element due to https://github.com/hashicorp/terraform-provider-aws/issues/23299

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested review from a team as code owners February 23, 2022 20:18
@renovate renovate bot requested review from jhosteny and woz5999 and removed request for a team February 23, 2022 20:18
@renovate renovate bot added the auto-update This PR was automatically generated label Feb 23, 2022
@Nuru Nuru closed this in #70 Feb 24, 2022
@renovate renovate bot deleted the renovate/cloudposse-s3-bucket-aws-0.x branch March 4, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update This PR was automatically generated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants