Rename lifecycle rules and split tag lifecycle filter #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknysh
reviewed
Feb 6, 2019
variables.tf
Outdated
| @@ -57,22 +62,22 @@ variable "force_destroy" { | |||
| } | |||
|
|
|||
| variable "lifecycle_rule_enabled" { | |||
| description = "(Optional) enable lifecycle events on this bucket" | |||
| description = "enable lifecycle events on this bucket" | |||
There was a problem hiding this comment.
Suggested change
| description = "enable lifecycle events on this bucket" | |
| description = "Enable lifecycle events on this bucket" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tagsgenerated by the label module were propagated to the S3 Lifecycle filters, this is in general not desired, as it means the lifecycle only applies to objects with those tags.Console help message for the setting:
Reference: https://docs.aws.amazon.com/AmazonS3/latest/API/RESTBucketPUTlifecycle.html
This adds a new var
lifecycle_tagswhich is a map of the tags to apply to the lifecycle rule