Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract the bucket id to a variable #197

Closed
wants to merge 2 commits into from
Closed

extract the bucket id to a variable #197

wants to merge 2 commits into from

Conversation

nikpivkin
Copy link

what

Extract the bucket id to a variable

why

Reducing code duplication

@nikpivkin nikpivkin marked this pull request as ready for review July 5, 2023 17:59
@nikpivkin nikpivkin requested review from a team as code owners July 5, 2023 17:59
@nikpivkin nikpivkin requested review from dotCipher and srhopkins July 5, 2023 17:59
@joe-niland joe-niland added the patch A minor, backward compatible change label Jul 6, 2023
@joe-niland
Copy link
Member

Hi @nikpivkin as per the check failure:

README.md is outdated. Please run the following commands locally and push the file:
  make init
  make readme

Do you mind doing these and pushing?

@joe-niland joe-niland self-requested a review July 6, 2023 00:39
@nikpivkin
Copy link
Author

Hi @joe-niland , done.

@joe-niland joe-niland added patch A minor, backward compatible change and removed patch A minor, backward compatible change labels Jul 8, 2023
@Nuru Nuru mentioned this pull request Aug 26, 2023
Merged
@Nuru Nuru closed this in #202 Aug 26, 2023
@nikpivkin nikpivkin deleted the extract-var branch June 24, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher is a code owner automatically assigned from cloudposse/contributors

@srhopkins srhopkins Awaiting requested review from srhopkins srhopkins is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikpivkin @joe-niland