Allow passing existing sns topic var #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-niland
requested review from
Makeshift and
woz5999
and removed request for
a team
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
| create_sns_topic = var.aws_sns_topic_arn == "" | ||
| aws_sns_topic_arn = local.create_sns_topic ? aws_sns_topic.default.*.arn : [var.aws_sns_topic_arn] | ||
| } | ||
|
|
||
| resource "aws_sns_topic" "default" { |
There was a problem hiding this comment.
Ensure AWS SNS topic has SSE enabled
Resource: aws_sns_topic.default | ID: BC_AWS_GENERAL_15
How to Fix
resource "aws_sns_topic" "example" {
...
name = "user-updates-topic"
+ kms_master_key_id = "alias/aws/sns"
}Description
Amazon SNS is a publishers and subscribers messaging service. When you publish messages to encrypted topics, customer master keys (CMK), powered by AWS KMS, can be used to encrypt your messages.If you operate in a regulated market, such as HIPAA for healthcare, PCI DSS for finance, or FedRAMP for government, you need to ensure sensitive data messages passed in this service are encrypted at rest.
Benchmarks
- PCI-DSS V3.2 3
- FEDRAMP (MODERATE) SC-28
|
/test all |
| create_sns_topic = var.aws_sns_topic_arn == "" | ||
| aws_sns_topic_arn = local.create_sns_topic ? aws_sns_topic.default.*.arn : [var.aws_sns_topic_arn] | ||
| } | ||
|
|
||
| resource "aws_sns_topic" "default" { |
There was a problem hiding this comment.
Ensure AWS SNS topic has SSE enabled
Resource: module.rds_alarms.aws_sns_topic.default | ID: BC_AWS_GENERAL_15
How to Fix
resource "aws_sns_topic" "example" {
...
name = "user-updates-topic"
+ kms_master_key_id = "alias/aws/sns"
}Description
Amazon SNS is a publishers and subscribers messaging service. When you publish messages to encrypted topics, customer master keys (CMK), powered by AWS KMS, can be used to encrypt your messages.If you operate in a regulated market, such as HIPAA for healthcare, PCI DSS for finance, or FedRAMP for government, you need to ensure sensitive data messages passed in this service are encrypted at rest.
Benchmarks
- PCI-DSS V3.2 3
- FEDRAMP (MODERATE) SC-28
🎉 Fixed by commit 9580fac - Add test for existing SNS topic
|
/test all |
|
/test bats |
|
/test terratest |
|
/test terratest |
|
/test terratest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
references