Fix bucket name in policy statements, fixing #81

[benjamin-hg]

what

• Limit generated S3 bucket name to 63 characters

why

• AWS imposed limit, derived from DNS limits, allowing S3 buckets to be accessed by name via DNS

references

• closes Deployment fails with "MalformedPolicy: Policy has invalid resource" when used as part of terraform-aws-elastic-beanstalk-environment #81
• Copy bucket_name logic from dependent module

[benjamin-hg]

After rm -rf .terraform/modules and terraform init, my deployment actually fails with this patch applied. Seems like I was not working with the defined modules versions.

I'm using cloudposse/elastic-beanstalk-environment/aws v0.51.2 and it still fails.

[nitrocode]

/test-terratest

[nitrocode]

/test terratest

[nitrocode]

/terratest

[benjamin-hg]

@nitrocode I guess terratest failed because the test does not set the bucket name and hence the module was disabled. Hope fb07687 fixes the issue

[nitrocode]

@benjamin-hg please

1. revert fb07687
2. copy the same variable definition of bucket_name from the upstream module to

   terraform-aws-lb-s3-bucket/variables.tf

   Lines 7 to 11 in 804778a

   	variable "bucket_name" {
   	type = string
   	default = null
   	description = "Bucket name. If provided, the bucket will be created with this name instead of generating the name from the context"
   	}

[benjamin-hg]

@benjamin-hg please

1. revert fb07687
2. copy the same variable definition of bucket_name from the upstream module to

   terraform-aws-lb-s3-bucket/variables.tf

   Lines 7 to 11 in 804778a

   	variable "bucket_name" {
   	type = string
   	default = null
   	description = "Bucket name. If provided, the bucket will be created with this name instead of generating the name from the context"
   	}

@nitrocode I'm sorry but I didn't get it. 😬

1. Before fb07687, terratest was failing because the name of the bucket was empty in the resource of the policy statement. Setting the bucket_name module to enabled by default (if bucket_name variable is not set) should solve the issue that the bucket name taken from the bucket_name module is empty because the module is not enabled. Why do you think this can be reverted?

2. The variable definition is already there:
   https://github.com/benjamin-hg/terraform-aws-lb-s3-bucket/blob/18bed393e11e76b4346893f1f264ebe883abca2c/variables.tf#L7-L11 so copying it over would not cause any change.

[nitrocode]

Hmm I'm unsure here but it seems like changing the false to true may maintain the bucket name null label (via the enabled flag) if the var.bucket_name = null which seems wrong.

Let me cc others in this PR @kevcube @RoseSecurity

@benjamin-hg you may also want to post in sweetops slack community's #pr-reviews for more visibility.

[milldr]

/terratest

[Nuru]

/terratest