fix: ignores password_reset_required change to support changes in AWS provider 4.x

[gberenice]

what

• Ignores password_reset_required change.

why

• There is a bug/feature(?) in AWS provider 4.x that causes undesired user update, see this open issue Resource aws_iam_user_login_profile "forces replacement" after upgrade to aws provider v4x hashicorp/terraform-provider-aws#23567. Know fix for now is to ignore this change.

references

• Resource aws_iam_user_login_profile "forces replacement" after upgrade to aws provider v4x hashicorp/terraform-provider-aws#23567)

[Gowiem]

@gberenice Looks simple and solid, but one question on the change shared below! 💯 🚀 👋

[Gowiem]

Hm... Does adding the lifecycle block force a recreate of this resource? What does that do for existing IAM users that you're managing?

[gberenice]

After upgrade of AWS provider to 4.x (in our case - to 4.21, without any change to root module configuration or terraform vars) the resource was forced to recreate:

  # module.users["veronika_gnilitska"].aws_iam_user_login_profile.default[0] must be replaced
-/+ resource "aws_iam_user_login_profile" "default" {
      ~ encrypted_password      = "wcBMAwEF3O2PIAyrAQgAvoQ6klRbbQ705f0Pj6l9uf4C/9GOdVfiEqmBkendM3dKPRkbbcJVXRP80xaTkElae17OiS69QJVji3/sS3ru2TLnFyZcNtSMayu9sodi2VDbNOhN6FRywuv9OBkBcgDu7686pOZLG27H2zT7V18sBwYR6bDaUepnLtDLq" -> (known after apply)
      ~ id                      = "veronika.gnilitska" -> (known after apply)
      ~ key_fingerprint         = "92f19546ec0f7d7ca8f9d" -> (known after apply)
      + password                = (known after apply)
      ~ password_reset_required = false -> true # forces replacement
        # (3 unchanged attributes hidden)
    }

If you apply this plan you won't be able to login with the credentials used before the apply. To avoid this behaviour for existing users - lifecycle was used.

[Gowiem]

👍 👍

[gberenice]

@Gowiem thank you! 💯

[Gowiem]

/test all

[gberenice]

@Gowiem oh, I see that some check were failed, but I doubt that it's related to introduced changes:

Terraform  is required for master...
+ [[ '' =~ ^1\. ]]
+ PATH_TO_TERRAFORM=/usr/local/terraform//bin
+ '[' -x /usr/local/terraform//bin/terraform ']'
+ echo 'Unable to locate executable for terraform '
Unable to locate executable for terraform 

Could you please advise how it can be fixed?

[Gowiem]

@gberenice the issue is due to a missing versions.tf in examples/complete. Can you copy the root versions.tf to examples/complete and we'll give that a shot?

[Gowiem]

/test all

[gberenice]

@Gowiem awesome, that worked! 😃
Is it possible to merge it now, or should I wait something?

[Gowiem]

@gberenice Solid work -- Thanks for the fix! Released as https://github.com/cloudposse/terraform-aws-iam-user/releases/tag/0.8.2