Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated data template_file with templatefile function #89

Merged
merged 6 commits into from
Jul 11, 2022

Conversation

carl-reverb
Copy link
Contributor

what

  • Replace deprecated data template_file with templatefile function

why

  • Users of arm architecture computers cannot use deprecated template provider

references

main.tf Outdated
data "aws_iam_instance_profile" "default" {
count = local.enabled && var.use_existing_aws_iam_instance_profile ? 1 : 0
name = var.aws_iam_instance_profile_name
}

module "autoscale_group" {
module "autoscale_roup" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
module "autoscale_roup" {
module "autoscale_group" {

@nitrocode
Copy link
Member

Please see comment and run make pr/readme locally to fix the Auto Format failure.

@nitrocode
Copy link
Member

It seems that the bot may not be able to update the PR. Could you allow the bot to make changes ? Usually personal forks allow this out of the box and only company specific forks prevent this.

@carl-reverb
Copy link
Contributor Author

I have added the bot as a contributor but its owner must accept the invitation so that I may assign the proper permission.

@nitrocode
Copy link
Member

cc: @aknysh @Gowiem for visibility. Not sure what to do here. Usually we do not need to accept the invite. Perhaps there is another workaround ? Usually open source forks of our repos that are non-company specific orgs work out of the box.

Also, please try pushing a new commit to rerun the auto format check.

@carl-reverb
Copy link
Contributor Author

@nitrocode I do not mind if you just copy and repost this branch from an in-house account which is able to complete the required checks. Just trying to be a good open source citizen here.

@nitrocode
Copy link
Member

We could. I think another way is if you could run make pr/auto-format locally and push up the files. If you have time, could you do this ?

@mergify
Copy link

mergify bot commented Jul 11, 2022

This pull request is now in conflict. Could you fix it @carl-reverb? 🙏

@Nuru Nuru requested review from a team as code owners July 11, 2022 21:36
@Nuru Nuru requested review from Gowiem and Benbentwo July 11, 2022 21:36
@Nuru Nuru added the no-release Do not create a new release (wait for additional code changes) label Jul 11, 2022
@Nuru Nuru merged commit cbdcbd1 into cloudposse:master Jul 11, 2022
@carl-reverb carl-reverb deleted the issue-87 branch July 14, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated template provider should be removed from module
4 participants