-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mixed instance policy support #32
Add mixed instance policy support #32
Conversation
cloudposse/terraform-aws-ec2-autoscale-group#19 adds support for the ability to specify different instances types and spot/on demand configurations for a launch template. This extends this functionality to eks nodes
/codefresh run test |
Any thoughts here @maximmi ? It looks like upstream module for asg's mixed_instances_policy is defined as a variable but it looks like terraform is unable to pick it up in codefresh, also experiencing the same on my local machine.
|
Edit, I just saw that there were two tags published and I was using the outdated one. It was able to resolve mixed_instance_policy after I bumped it. |
Ran:
Didn't see any deltas unless there is something else I need to add. Could you take a look again @maximmi ? Thanks! |
/codefresh run test |
/codefresh run test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @bnutt , you've missed quotes around variable name, but I've fixed it
ahh, thanks @maximmi , explains why the doc didn't generate it. i've added it locally to test and can see that it properly generated the docs. thanks for the change/review! |
@bnutt thanks for your contribution! please, check for recent release: https://github.com/cloudposse/terraform-aws-eks-workers/releases/tag/0.13.0 |
cloudposse/terraform-aws-ec2-autoscale-group#19 adds support for the ability to specify different instances types and spot/on demand configurations for a launch template. This extends this functionality to eks nodes