Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bootstrap-extra-args): Use KUBELET_EXTRA_ARGS env variable to pass extra kubelet args #27

Merged
merged 2 commits into from
Nov 7, 2019

Conversation

vymarkov
Copy link
Contributor

@vymarkov vymarkov commented Nov 7, 2019

I've faced with issue passing node labels to bootstrap.sh, the bootstrap cannot completed when we pass extra kubelet args as an argument, and thus node won't join to the kubernetes cluster.

Pass extra kubelet args via KUBELET_EXTRA_ARGS solves this.

@aknysh
Copy link
Member

aknysh commented Nov 7, 2019

/codefresh run test

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @vymarkov

@aknysh aknysh merged commit 34a43c2 into cloudposse:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants