Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to TF 0.12. Add tests. Add Codefresh test pipeline #23

Merged
merged 10 commits into from
Sep 26, 2019
Merged

Convert to TF 0.12. Add tests. Add Codefresh test pipeline #23

merged 10 commits into from
Sep 26, 2019

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Sep 26, 2019 •
edited
Loading

what

  • Port module to Terraform 0.12
  • Pin all providers
  • Add example for testing
  • Add bats and terratest for the example
  • Add Codefresh badge to point to the test pipeline in terraform-modules project
  • Update README
  • Rename outpute
    • from worker_role_arn to workers_role_arn
    • from worker_role_name to workers_role_name

why

  • Module currently does not work with 0.12. Much easier syntax
  • Better regression control
  • Automatically test the example on every commit and pull request
  • Provision resources on AWS in the test account and check the outputs for the correct values
  • terraform-modules project contains pipelines for all terraform modules
  • Rename outputs to reflect that the cluster has many worker nodes

related

@aknysh aknysh requested review from osterman and goruha September 26, 2019 02:10
@aknysh aknysh self-assigned this Sep 26, 2019
osulli
osulli reviewed Sep 26, 2019
View reviewed changes
outputs.tf
}

output "worker_role_arn" {
output "workers_role_arn" {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we note this in the PR please? I depend on this output of the module :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the PR description.
Renaming those outputs is not strictly necessary, but it reflects that the cluster has many workers. And since the new TF 0.12 module has many other changes, you will need to update it anyway

@osulli
Copy link

osulli commented Sep 26, 2019

@gramidt
@addisonj
FYI

@aknysh aknysh merged commit d3e954e into master Sep 26, 2019
@aknysh aknysh deleted the terraform-0.12 branch September 26, 2019 17:37
vymarkov pushed a commit to vymarkov/terraform-aws-eks-workers that referenced this pull request Nov 10, 2019
@osulli @aknysh
Cluster improvements (cloudposse#23)
e4b29b1 
* Remove need for 'workers_security_group_count'

* Remove documentation of sec_group_count

* Asd multi worker example

* Lint

* README

* Update Example

* Remove duplicate resource name

* Lint example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osulli osulli osulli left review comments

@osterman osterman osterman approved these changes

@goruha goruha Awaiting requested review from goruha

Assignees

@aknysh aknysh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_iam_role tags not defined
3 participants
@aknysh @osulli @osterman