Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow service role to be passed in #116

Merged
merged 16 commits into from
Jun 15, 2021
Merged

Allow service role to be passed in #116

merged 16 commits into from
Jun 15, 2021

Conversation

nitrocode
Copy link
Member

what

  • Accept eks_cluster_service_role_arn as a paramater to use an already defined eks service role instead of creating one.

why

  • Allows module to be run without IAM:CreateRole
  • Allows reuse of an already created service role.

references

@Tritium-VLK

@nitrocode nitrocode requested review from a team as code owners June 7, 2021 22:23
@nitrocode nitrocode requested review from jamengual and 3h4x June 7, 2021 22:24
@nitrocode nitrocode force-pushed the allow_service_role_to_be_passed_in branch from 3e05f6e to 6a0d4d5 Compare June 7, 2021 22:29
@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@mergify
Copy link

mergify bot commented Jun 15, 2021

This pull request is now in conflict. Could you fix it @nitrocode? 🙏

@nitrocode
Copy link
Member Author

/test all

korenyoni
korenyoni previously approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@korenyoni korenyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

aknysh
aknysh reviewed Jun 15, 2021
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
korenyoni
korenyoni reviewed Jun 15, 2021
View reviewed changes
iam.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jun 15, 2021
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGˇM, just a small nitpick

@nitrocode @aknysh
Update variables.tf
8c0c82c 
Co-authored-by: Andriy Knysh <[email protected]>
@nitrocode
Copy link
Member Author

/test all

korenyoni
korenyoni previously approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@korenyoni korenyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mergify mergify bot dismissed korenyoni’s stale review June 15, 2021 18:54

This Pull Request has been updated, so we're dismissing all reviews.

@nitrocode nitrocode requested review from korenyoni and aknysh June 15, 2021 19:28
@nitrocode nitrocode merged commit c25940a into master Jun 15, 2021
@nitrocode nitrocode deleted the allow_service_role_to_be_passed_in branch June 15, 2021 19:36
@Nuru Nuru mentioned this pull request Jul 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korenyoni korenyoni korenyoni approved these changes

@jamengual jamengual Awaiting requested review from jamengual

@3h4x 3h4x Awaiting requested review from 3h4x

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nitrocode @aknysh @korenyoni @Tritium-VLK @cloudpossebot