Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Perma-Drift with Replicas #107

Merged
merged 5 commits into from
Oct 24, 2022
Merged

Fix Perma-Drift with Replicas #107

merged 5 commits into from
Oct 24, 2022

Conversation

milldr
Copy link
Member

@milldr milldr commented Oct 19, 2022 •
edited
Loading

what

  • Explicitly set replica attributes as the default values

why

  • If using replicas, we always see drift for plans if those values are not set

references

@milldr milldr requested review from a team as code owners October 19, 2022 23:06
@milldr milldr requested review from Gowiem and korenyoni October 19, 2022 23:06
bridgecrew[bot]
bridgecrew bot reviewed Oct 19, 2022
View reviewed changes
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found errors in this PR ⬇️

main.tf Show resolved Hide resolved
bridgecrew[bot]
bridgecrew bot reviewed Oct 19, 2022
View reviewed changes
main.tf Show resolved Hide resolved
@milldr
Copy link
Member Author

milldr commented Oct 19, 2022

/test all

bridgecrew[bot]
bridgecrew bot reviewed Oct 19, 2022
View reviewed changes
main.tf Show resolved Hide resolved
bridgecrew[bot]
bridgecrew bot reviewed Oct 19, 2022
View reviewed changes
main.tf Show resolved Hide resolved
bridgecrew[bot]
bridgecrew bot reviewed Oct 19, 2022
View reviewed changes
main.tf Show resolved Hide resolved
@milldr
Copy link
Member Author

milldr commented Oct 20, 2022

/test all

bridgecrew[bot]
bridgecrew bot reviewed Oct 20, 2022
View reviewed changes
main.tf Show resolved Hide resolved
bridgecrew[bot]
bridgecrew bot reviewed Oct 20, 2022
View reviewed changes
main.tf Show resolved Hide resolved
@milldr
Copy link
Member Author

milldr commented Oct 20, 2022

/test all

bridgecrew[bot]
bridgecrew bot reviewed Oct 20, 2022
View reviewed changes
main.tf Show resolved Hide resolved
@milldr milldr mentioned this pull request Oct 20, 2022
Merged
@milldr milldr merged commit 7f1a7b0 into master Oct 24, 2022
@milldr milldr deleted the fix_replica_plan branch October 24, 2022 23:29
@ivanmartos ivanmartos mentioned this pull request Nov 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridgecrew bridgecrew[bot] bridgecrew[bot] left review comments

@aknysh aknysh aknysh approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem was automatically assigned from cloudposse/contributors

@korenyoni korenyoni Awaiting requested review from korenyoni korenyoni was automatically assigned from cloudposse/contributors

@goruha goruha Awaiting requested review from goruha

@osterman osterman Awaiting requested review from osterman

Assignees

@milldr milldr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subsequent apply with replicas triggers replicas rebuild.
3 participants
@milldr @aknysh @cloudpossebot