Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

count replaced with foreach #37

Merged
merged 2 commits into from
May 20, 2021
Merged

count replaced with foreach #37

merged 2 commits into from
May 20, 2021

Conversation

maximmi
Copy link
Contributor

@maximmi maximmi commented May 20, 2021

what

  • count replaced with foreach

why

  • requires to fix invalid count argument on read/write_target_index with multiple dynamodb tables issue

refs

@maximmi maximmi requested a review from goruha May 20, 2021 09:36
@maximmi maximmi requested review from a team as code owners May 20, 2021 09:36
@maximmi maximmi requested review from jamengual and brcnblc May 20, 2021 09:36
@maximmi
Copy link
Contributor Author

maximmi commented May 20, 2021

/test all

@mwarkentin
Copy link

@maximmi @goruha I think this has introduced a bug (IMO) where autoscaling resources are trying to be created when using the terraform-aws-dynamodb module even if enable_autoscaler = false. I opened cloudposse/terraform-aws-dynamodb#92 on the other module with more details.

mwarkentin added a commit to mwarkentin/terraform-aws-dynamodb that referenced this pull request May 20, 2021
after cloudposse/terraform-aws-dynamodb-autoscaler#37 was merged, some autoscaler resources were automatically created, even if enable_autoscaler = false

Closes cloudposse#92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants