Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform 0.14 upgrade #31

Merged
merged 3 commits into from
Feb 4, 2021
Merged

Terraform 0.14 upgrade #31

merged 3 commits into from
Feb 4, 2021

Conversation

maximmi
Copy link
Contributor

@maximmi maximmi commented Jan 5, 2021

what

  • Upgrade to support Terraform 0.14 and bring up to current Cloud Posse standard

why

  • Support Terraform 0.14

@maximmi maximmi requested review from a team as code owners January 5, 2021 16:03
@maximmi maximmi requested review from dotCipher and woz5999 January 5, 2021 16:03
@maximmi maximmi self-assigned this Jan 5, 2021
@mcalhoun
Copy link
Member

mcalhoun commented Jan 6, 2021

/test all

Copy link
Member

@mcalhoun mcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you use expressions in an if conditional, you may omit the expression syntax (${{ }}) because GitHub automatically evaluates the if conditional as an expression. For more information about if conditionals, see Workflow syntax for GitHub Actions.

@maximmi maximmi requested a review from a team as a code owner January 7, 2021 09:33
@maximmi
Copy link
Contributor Author

maximmi commented Jan 7, 2021

/test all

@maximmi
Copy link
Contributor Author

maximmi commented Jan 7, 2021

/rebuild-readme

@maximmi
Copy link
Contributor Author

maximmi commented Jan 7, 2021

/test all

@maximmi maximmi requested a review from mcalhoun January 7, 2021 09:42
@maximmi maximmi dismissed mcalhoun’s stale review January 7, 2021 09:43

Comment addressed

Copy link
Member

@mcalhoun mcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -34,7 +34,7 @@ jobs:
fi

- name: Create Pull Request
if: steps.update.outputs.create_pull_request == 'true'
if: {{ steps.update.outputs.create_pull_request == 'true' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you use expressions in an if conditional, you may omit the expression syntax (${{ }}) because GitHub automatically evaluates the if conditional as an expression. For more information about if conditionals, see Workflow syntax for GitHub Actions.

@osterman osterman merged commit c2fb5df into master Feb 4, 2021
@osterman osterman deleted the terraform-0.14-upgrade branch February 4, 2021 06:55
sidprak added a commit to verkada/terraform-aws-dynamodb-autoscaler that referenced this pull request Apr 28, 2021
* make this module v14 compatible (cloudposse#27)

Co-authored-by: actions-bot <[email protected]>

* Terraform 0.14 upgrade (cloudposse#28)

* Fix auto-context and validate-codeowners (cloudposse#29)

* Update README.md and docs (cloudposse#30)

Co-authored-by: Nuru <[email protected]>

* Terraform 0.14 upgrade (cloudposse#31)

* Terraform 0.14 upgrade

* updated workflows

* Updated README.md

Co-authored-by: actions-bot <[email protected]>

* context.tf updated to v0.24.1, minimum required Terraform version bumped to 0.13.0 when needed, readme updated (cloudposse#33)

Co-authored-by: Jürgen W <[email protected]>
Co-authored-by: actions-bot <[email protected]>
Co-authored-by: Nuru <[email protected]>
Co-authored-by: Cloud Posse Bot (CI/CD) <[email protected]>
Co-authored-by: Maxim Mironenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants