Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable helm experiments by default, block Kubernetes provider 2.21.0 #712

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Jun 5, 2023

what

  • Set helm_manifest_experiment_enabled to false by default
  • Block Kubernetes provider 2.21.0

why

  • The helm_manifest_experiment_enabled reliably breaks when a Helm chart installs CRDs. The initial reason for enabling it was for better drift detection, but the provider seems to have fixed most if not all of the drift detection issues since then.
  • Kubernetes provider 2.21.0 had breaking changes which were reverted in 2.21.1.

references

@Nuru Nuru requested review from a team as code owners June 5, 2023 22:22
@Nuru Nuru enabled auto-merge (squash) June 5, 2023 22:24
@Nuru Nuru merged commit c869cb2 into main Jun 5, 2023
@Nuru Nuru deleted the provider-helm.tf branch June 5, 2023 22:30
goruha pushed a commit to cloudposse-terraform-components/aws-datadog-synthetics-private-location that referenced this pull request Nov 27, 2024
goruha pushed a commit to cloudposse-terraform-components/aws-eks-actions-runner-controller that referenced this pull request Nov 27, 2024
goruha pushed a commit to cloudposse-terraform-components/aws-eks-alb-controller that referenced this pull request Nov 27, 2024
goruha pushed a commit to cloudposse-terraform-components/aws-eks-alb-controller-ingress-class that referenced this pull request Nov 27, 2024
goruha pushed a commit to cloudposse-terraform-components/aws-eks-alb-controller-ingress-group that referenced this pull request Nov 27, 2024
goruha pushed a commit to cloudposse-terraform-components/aws-eks-argocd that referenced this pull request Nov 27, 2024
goruha pushed a commit to cloudposse-terraform-components/aws-eks-node-termination-handler that referenced this pull request Nov 27, 2024
goruha pushed a commit to cloudposse-terraform-components/aws-eks-cert-manager that referenced this pull request Nov 27, 2024
goruha pushed a commit to cloudposse-terraform-components/aws-eks-datadog-agent that referenced this pull request Nov 27, 2024
goruha pushed a commit to cloudposse-terraform-components/aws-eks-echo-server that referenced this pull request Nov 27, 2024
goruha pushed a commit to cloudposse-terraform-components/aws-eks-external-dns that referenced this pull request Nov 27, 2024
goruha pushed a commit to cloudposse-terraform-components/aws-eks-external-secrets-operator that referenced this pull request Nov 27, 2024
goruha pushed a commit to cloudposse-terraform-components/aws-eks-idp-roles that referenced this pull request Nov 27, 2024
goruha pushed a commit to cloudposse-terraform-components/aws-eks-karpenter-controller that referenced this pull request Nov 27, 2024
goruha pushed a commit to cloudposse-terraform-components/aws-eks-metrics-server that referenced this pull request Nov 27, 2024
goruha pushed a commit to cloudposse-terraform-components/aws-eks-redis that referenced this pull request Nov 27, 2024
goruha pushed a commit to cloudposse-terraform-components/aws-eks-redis-operator that referenced this pull request Nov 27, 2024
goruha pushed a commit to cloudposse-terraform-components/aws-eks-reloader that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants