Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove third-party libs. Simplify code. Add comments #7

Merged
merged 8 commits into from
Feb 1, 2018
Merged

Conversation

aknysh
Copy link
Contributor

@aknysh aknysh commented Jan 31, 2018

what

  • Removed third-party libs
  • Simplified code
  • Added comments

why

  • Use PHP DOMDocument class instead of third-party libs for DOM parsing
  • To conform to PHP doc guidelines

@aknysh aknysh self-assigned this Jan 31, 2018
@aknysh aknysh requested a review from osterman January 31, 2018 19:34
Copy link

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we change to GPL?

osterman
osterman previously approved these changes Feb 1, 2018
@aknysh aknysh merged commit ce65839 into master Feb 1, 2018
@aknysh aknysh deleted the simplify branch February 1, 2018 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants