-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#140] Raise Dependencies #141
Conversation
notmyown
commented
Dec 6, 2024
- Update Groovy to 3.0.23
- Update JUnit to 5.11.3 and added groovy-test-junit5:3.0.23
- Update Mockito to 4.5.1
- Update Hamcrest to 3.0
- Update Maven to 3.9.9
- maven-compiler-plugin to 3.13.0
- Update Groovy to 3.0.23 - Update JUnit to 5.11.3 and added groovy-test-junit5:3.0.23 - Update Mockito to 4.5.1 - Update Hamcrest to 3.0 - Update Maven to 3.9.9 - maven-compiler-plugin to 3.13.0
The "toString" Methode needs to be called on String-look-a-likes "${variable}" Because it is no real java.Lang.String but a GStringImpl of Groovy. An assert must fail in direct comparison. To get a default String in groovy use single-quotes. |
Sorry for chiming in unasked. Until before this PR, leaving the version on 2 protected us from using groovy code that would later fail on Jenkins because of lacking syntactic support. It would be great, though, to use latest Groovy 4 features, e.g. in test and for latest security fixes. |
@@ -9,7 +11,7 @@ import static org.mockito.ArgumentMatchers.anyString | |||
import static org.mockito.Mockito.mock | |||
import static org.mockito.Mockito.when | |||
|
|||
class K3dTest extends GroovyTestCase { | |||
class K3dTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally arriving in year 2010 with tests that no longer extend other testcases 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you. LGTM
Oh that's an important note which I didn't had on my 2024 card: "Tooling still on Groovy 2.x" 😞 Thanks for the info 👏 |
PR obsolet due to other Branch - fixing the Groovy 3 - Jenkins issue |