Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#140] Raise Dependencies #141

Closed
wants to merge 2 commits into from
Closed

Conversation

notmyown
Copy link

@notmyown notmyown commented Dec 6, 2024

  • Update Groovy to 3.0.23
  • Update JUnit to 5.11.3 and added groovy-test-junit5:3.0.23
  • Update Mockito to 4.5.1
  • Update Hamcrest to 3.0
  • Update Maven to 3.9.9
  • maven-compiler-plugin to 3.13.0

Marco Bergen added 2 commits December 6, 2024 11:46
- Update Groovy to 3.0.23
- Update JUnit to 5.11.3 and added groovy-test-junit5:3.0.23
- Update Mockito to 4.5.1
- Update Hamcrest to 3.0
- Update Maven to 3.9.9
- maven-compiler-plugin to 3.13.0
@notmyown notmyown linked an issue Dec 6, 2024 that may be closed by this pull request
@notmyown
Copy link
Author

notmyown commented Dec 6, 2024

The "toString" Methode needs to be called on String-look-a-likes "${variable}" Because it is no real java.Lang.String but a GStringImpl of Groovy. An assert must fail in direct comparison.

To get a default String in groovy use single-quotes.

@schnatterer
Copy link
Member

Sorry for chiming in unasked.
Please don't upgrade Groovy version.
AFAIK Groovy in Jenkins is still on 2.x (see screenshot bellow).

Until before this PR, leaving the version on 2 protected us from using groovy code that would later fail on Jenkins because of lacking syntactic support.

It would be great, though, to use latest Groovy 4 features, e.g. in test and for latest security fixes.
Maybe there is way to configure the groovy compiler to check groovy 2 compatibility mode, similar to Javas source level?

image

@@ -9,7 +11,7 @@ import static org.mockito.ArgumentMatchers.anyString
import static org.mockito.Mockito.mock
import static org.mockito.Mockito.when

class K3dTest extends GroovyTestCase {
class K3dTest {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally arriving in year 2010 with tests that no longer extend other testcases 😆

Copy link
Member

@ppxl ppxl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you. LGTM

@ppxl
Copy link
Member

ppxl commented Dec 9, 2024

Sorry for chiming in unasked. Please don't upgrade Groovy version. AFAIK Groovy in Jenkins is still on 2.x (see screenshot bellow).

Until before this PR, leaving the version on 2 protected us from using groovy code that would later fail on Jenkins because of lacking syntactic support.

It would be great, though, to use latest Groovy 4 features, e.g. in test and for latest security fixes. Maybe there is way to configure the groovy compiler to check groovy 2 compatibility mode, similar to Javas source level?

image

Oh that's an important note which I didn't had on my 2024 card: "Tooling still on Groovy 2.x" 😞

Thanks for the info 👏

@notmyown notmyown self-assigned this Dec 12, 2024
@notmyown
Copy link
Author

PR obsolet due to other Branch - fixing the Groovy 3 - Jenkins issue

@notmyown notmyown closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies
3 participants