feat(cluster) add ServiceAccountTemplate annotations and labels #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dariusch Ochlast <[email protected]>
Dariusch
requested review from
itay-grudev,
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco and
sxd
as code owners
|
Would really like this feature, if there's anything I can do to help out, let me know! |
|
Same here, would really need this |
|
@Dariusch While your solution is perfectly valid and makes sense. I would like to pass the whole |
|
Closed in favor of #463. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/KnechtionsCoding/helm-schema-gen.gitand up-to-date fork of the originalhttps://github.com/karuppiah7890/helm-schema-gen.gitwhich is not compatible with macOS.fixes #309