feat(cloudnative-pg): Add structured field monitoringQueriesConfigMap.queriesData #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgebarbarosie
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco and
sxd
as code owners
|
@georgebarbarosie can you check the error with the DCO? https://github.com/cloudnative-pg/charts/runs/14778552401 |
Uses same syntax as `queries`, but it's plain Yaml instead of yaml-as-string. The values in both fields are merged. Signed-off-by: George Barbarosie <[email protected]>
Done. Apologies, I wasn't aware of the requirement. |
itay-grudev
changed the title
itay-grudev
added
the
chart( operator )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses same syntax as
queries, but it's plain Yaml instead of yaml-as-string. The values in both fields are merged, withqueriesDataoverriding values fromqueries.We pass queries through
fromYaml, we then merge it withqueriesDataand use the result as the final value in the ConfigMap.The advantage of this is that it allows people to override specific queries in the default queries value and it allows composability for those that use e.g. kustomizations to compile the values of the chart (gitops, fluxcd, etc).