Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detachMedia deleting all files #96

Conversation

Delaney
Copy link
Contributor

@Delaney Delaney commented Oct 5, 2023

Summary

Fixes bug where non-null value in detachMedia method deletes only the specified media's model but deletes all associated media in the cloud.

Ticket Link

Fixes #51

Release Note

- Fix DetachMedia bug
- Add functionality to pass collection of Media to DetachMedia

Copy link
Collaborator

@unicodeveloper unicodeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⭐

Thanks for your contribution

@unicodeveloper unicodeveloper merged commit 20a133b into cloudinary-community:master Oct 5, 2023
@colbyfayock
Copy link
Collaborator

colbyfayock commented Oct 5, 2023

@Delaney congrats on the merged PR! since it's officially October, you've always qualified for Hacktoberfest swag! please email [email protected] with your github username and this PR where I'll follow up to request more information for getting you your swag

https://cloudinary.com/blog/hacktoberfest-celebrate-open-source-sdks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detachMedia deletes ALL images attached to an entity
3 participants