fix(checks): Cannot read properties of undefined (reading 'direction')

cloudgraphdev · May 17, 2023 · 700a3de · 700a3de
1 parent d1199a8
commit 700a3de
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/src/azure/pci-dss-3.2.1/rules/pci-dss-3.2.1-networking-check-1.ts b/src/azure/pci-dss-3.2.1/rules/pci-dss-3.2.1-networking-check-1.ts
@@ -81,6 +81,7 @@ export default {
     ]
     return !rules.some((rule: any) => {
       return (
+        rule &&
         rule.direction === 'Inbound' &&
         rule.access === 'Allow' &&
         ['TCP', 'Tcp', '*'].includes(rule.protocol) &&

diff --git a/src/azure/pci-dss-3.2.1/tests/pci-dss-3.2.1-networking-checks.test.ts b/src/azure/pci-dss-3.2.1/tests/pci-dss-3.2.1-networking-checks.test.ts
@@ -102,6 +102,7 @@ describe('PCI Data Security Standard: 3.2.1', () => {
                         destinationPortRanges:
                           fromPort && toPort ? [`${fromPort}-${toPort}`] : [],
                       },
+                      undefined as unknown as SecurityRule
                     ],
                   },
                 ],
-Original file line number
+Diff line change
@@ Expand Up / @@ -102,6 +102,7 @@ describe('PCI Data Security Standard: 3.2.1', () => { @@
                             destinationPortRanges:
                               fromPort && toPort ? [`${fromPort}-${toPort}`] : [],
                           },
+                          undefined as unknown as SecurityRule
                         ],
                       },
                     ],
@@ Expand Down @@