Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute scripts in injectHTML by default #541

Merged
merged 3 commits into from
Aug 4, 2022
Merged

Execute scripts in injectHTML by default #541

merged 3 commits into from
Aug 4, 2022

Conversation

calebeby
Copy link
Member

@calebeby calebeby commented Aug 2, 2022

Closes #526

@calebeby calebeby changed the title Execute scripts in injectHTML Execute scripts in injectHTML by default Aug 2, 2022
Paul-Hebert
Paul-Hebert approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@Paul-Hebert Paul-Hebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@calebeby calebeby merged commit 39085ac into main Aug 4, 2022
@calebeby calebeby deleted the injecthtml-execute-scripts branch August 4, 2022 20:10
@github-actions github-actions bot mentioned this pull request Aug 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paul-Hebert Paul-Hebert Paul-Hebert approved these changes

@spaceninja spaceninja Awaiting requested review from spaceninja

@gerardo-rodriguez gerardo-rodriguez Awaiting requested review from gerardo-rodriguez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should utils.injectHTML evaluate injected scripts?
2 participants
@calebeby @Paul-Hebert