Data and File Parsing #6
Conversation
* feature-rewrite: Make option translator function testable Add back undefined checking in merge utility Fix bad fixture key Relocate merge utility and add test WTactualF Bugfix merging function Add new merge function and attempt to use it on options
| import { merge } from './utils'; | ||
|
|
||
| const defaults = { | ||
| data: { | ||
| src: ['src/data/**/*.yaml'], | ||
| parseFn: (contents, path) => yaml.safeLoad(contents) |
There was a problem hiding this comment.
options can now take a parseFn to run over data files. This allows a user to parse with something else, e.g. JSON or something.
|
Hmmm, commit history looks a bit funky. The diffs look correct, however. |
| return dirname(filepath).split(path.sep).pop(); | ||
| } | ||
| function removeLeadingNumbers (str) { | ||
| return str.replace(/^[0-9|\.\-]+/, ''); |
There was a problem hiding this comment.
Can we add @examples to these functions to demonstrate the I/O?
Also, for removeLeadingNumbers, can we broaden the delimiters it will catch? I'm not sure what the original Fabricator did, but I would expect all of these to match:
Here's another pattern that might work:
There was a problem hiding this comment.
@erikjung Are you comfortable with a possible breaking change? I think this pattern is better, too, but will it cause unexpected side effects or should we be all "full speed ahead, damn the torpedoes"?!
There was a problem hiding this comment.
I've pushed some comments/examples on most of those utility functions.
There was a problem hiding this comment.
If we're using the pattern from Fabricator verbatim, then we can leave this as-is and make an issue to improve later.
|
@lyzadanger Looks good. I think it'd be nice to auto-generate some docs for this. |
|
@erikjung Yes, I'd like to generate some docs. You wanna take that on at some point? |
|
@lyzadanger Yeah, I'll make an issue. |
|
Looks good overall. Had to take a bit longer to get through it, but I generally process things slower. |
|
OK, I'm gonna merge for now! |
This PR introduces a bunch of generalized utility that will make it easier to parse various kinds of files and specifically handles the parsing of data files. It handles some options changes and a lot of tests.
/cc @erikjung @mrgerardorodriguez