-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: style gutenberg button same as c-button #729
Conversation
…atterns into chore/gutenberg-core-button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this seems reasonable to me. I'll defer to @tylersticka, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your mixins look great.
I would suggest applying them to wp-block-button__link
rather than wp-block-button
to solve the focus issues you mentioned earlier.
Overview
See #710
Creates a button mixin and applies our
c-button
styles to buttons output via Gutenberg button blocks. Selectors account for filled and outlined buttons as well as maintaining our desired colors and border radii.I failed to arrive a solution for styling
:focus
states due to the lack of buttons and the following HTML output:Screenshots
I've added an outlined markup example to the vendor → WordPress → Gutenberg → core/button example:
Testing output in a local version of our site:
Example of the available options within the button block editor:
Testing
:hover
:focus
Notes