Add logs in case of SAML issues (#3173)

These issues should be ignored, because they were ignored before. Issue type: 1. Invalid IdP setup, e.g. invalid metadata. Write an error, but start the UAA 2. Invalid resolution of SAMl metadata during runtime. Add warning for such problems.
cloudfoundry · Dec 3, 2024 · 46db36e · 46db36e
1 parent 9079cb3
commit 46db36e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...oudfoundry/identity/uaa/provider/saml/ConfiguratorRelyingPartyRegistrationRepository.java b/...oudfoundry/identity/uaa/provider/saml/ConfiguratorRelyingPartyRegistrationRepository.java
@@ -51,7 +51,7 @@ public RelyingPartyRegistration findByRegistrationId(String registrationId) {
                 }
             }
         } catch (Exception e) {
-            // ignore
+            log.warn("Cannot retrieve SAML trusted party.", e);
         }
 
         return null;

diff --git a/...cloudfoundry/identity/uaa/provider/saml/SamlRelyingPartyRegistrationRepositoryConfig.java b/...cloudfoundry/identity/uaa/provider/saml/SamlRelyingPartyRegistrationRepositoryConfig.java
@@ -88,7 +88,7 @@ RelyingPartyRegistrationRepository relyingPartyRegistrationRepository(SamlIdenti
             try {
                 relyingPartyRegistrations.add(RelyingPartyRegistrationBuilder.buildRelyingPartyRegistration(params));
             } catch (Saml2Exception e) {
-                // ignore
+                log.error("Error building relying party", e);
             }
         }