Skip to content

Commit

Permalink
remove node version line 10
Browse files Browse the repository at this point in the history
  • Loading branch information
arjun024 committed Jun 1, 2021
1 parent 06b4300 commit 6a14f44
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 19 deletions.
2 changes: 1 addition & 1 deletion fixtures/rails5/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"engines": {
"node": "10.x"
"node": "14.x"
}
}
16 changes: 0 additions & 16 deletions manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,6 @@ default_versions:
pre_package: scripts/build.sh
url_to_dependency_map: []
dependency_deprecation_dates:
- version_line: 10.x
name: node
date: 2021-04-30
link: https://github.com/nodejs/LTS
- version_line: 10.x.x
name: node
date: 2021-04-01
link: https://github.com/nodejs/Release
- version_line: 14.x.x
name: node
date: 2023-04-30
Expand Down Expand Up @@ -55,14 +47,6 @@ dependencies:
- cflinuxfs3
source: https://s3.amazonaws.com/jruby.org/downloads/9.2.17.0/jruby-src-9.2.17.0.tar.gz
source_sha256: 8700ae9097cfba0b37e1709c4a0baf996fdd2d76260eaf53a60f79f05af760e7
- name: node
version: 10.24.1
uri: https://buildpacks.cloudfoundry.org/dependencies/node/node_10.24.1_linux_x64_cflinuxfs3_80ce1404.tgz
sha256: 80ce1404d759d8838741d1e32fad9fac3a3f601dd15b38d27a54c7fd7211710e
cf_stacks:
- cflinuxfs3
source: https://nodejs.org/dist/v10.24.1/node-v10.24.1.tar.gz
source_sha256: 95c7cfc4b5ad0b5a62bd553b30840db66f21217fbeb769ab27dac8019a4ebe5d
- name: node
version: 14.17.0
uri: https://buildpacks.cloudfoundry.org/dependencies/node/node_14.17.0_linux_x64_cflinuxfs3_2ebd327c.tgz
Expand Down
4 changes: 2 additions & 2 deletions src/ruby/integration/node_supplied_for_ruby_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ var _ = Describe("running supply nodejs buildpack before the ruby buildpack", fu
PushAppAndConfirm(app)

Expect(app.Stdout.String()).To(ContainSubstring("Nodejs Buildpack version"))
Expect(app.Stdout.String()).To(ContainSubstring("Installing node 10."))
Expect(app.Stdout.String()).To(ContainSubstring("Installing node 14."))

body, err := app.GetBody("/")
Expect(err).To(BeNil())
Expect(body).To(ContainSubstring("Ruby version: ruby 2."))
Expect(body).To(ContainSubstring("Node version: v10."))
Expect(body).To(ContainSubstring("Node version: v14."))
Expect(body).To(ContainSubstring("/home/vcap/deps/0/node"))

Expect(app.Stdout.String()).To(ContainSubstring("Skipping install of nodejs since it has been supplied"))
Expand Down

0 comments on commit 6a14f44

Please sign in to comment.