Do not remove evacuating actual LRP during cleanup #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evacuating actual LRP will be removed by BBS convergence or after the replacement LRP is started. No need to bombard BBS during cell updates. This will minimize the drain time and it will actually stay close to the configured drain timeout. Cleanup is happening after the timeout is reached and BBS requests can overload BBS and cause it to timeout each request (10s) by default.
MarcPaquette
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Evacuating actual LRP will be removed by BBS convergence or after the replacement LRP is started. No need to bombard BBS during cell updates. This will minimize the drain time and it will actually stay close to the configured drain timeout. Cleanup is happening after the timeout is reached and BBS requests can overload BBS and cause it to timeout each request (10s) by default.
Backward Compatibility
Breaking Change? No