-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config to allow subset of processors and exporters #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! Just a few questions and concerns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor comments. Let's also rebase the commits and clean up the commit messages before merging this PR
933e54f
to
b5bc59d
Compare
This adds two new job properties that let's an operator restrict the kinds of OTel processors and exporters that can be used: `allow_list.processors` and `allow_list.exporters`. These properties are empty by default ([]), which keeps the existing behavior of allowing all processors and exporters that are included in our distribution. If not empty, then only the included components are allowed. Signed-off-by: Ivan Protsiuk <[email protected]> Signed-off-by: Matthew Kocher <[email protected]> Signed-off-by: Glenn Oppegard <[email protected]>
b5bc59d
to
002bd91
Compare
This adds two new job properties that let's an operator restrict the kinds of OTel processors and exporters that can be used:
allow_list.processors
andallow_list.exporters
. These properties are empty by default ([]
), which keeps the existing behavior of allowing all processors and exporters that are included in our distribution. If not empty, then only the included components are allowed. For example, givenallow_list.exporters: [otlp]
and aconfig
that contain theprometheus
exporter, an error will be raised during template rendering ofconfig.yml.erb
.Given the non-GA status of the majority of OTel components, using these new properties helps limit which of the components can be used by end-users (in our case, only the OTel Collector configuration yaml of
config
is exposed to end-users, and we can set the new allow list properties).We also added the
memory_limiter
processor in our distribution.