Rollback feature #221
Rollback feature #221
Conversation
theghost5800
force-pushed
the
rollback-feature
branch
from
0007bea to
43e41b9
Compare
commands/rollback_mta_command.go
Outdated
| cf rollback-mta -i OPERATION_ID -a ACTION [-u URL]`, | ||
| Options: map[string]string{ | ||
| deployServiceURLOpt: "Deploy service URL, by default 'deploy-service.<system-domain>'", | ||
| versionRuleOpt: "Version rule (HIGHER, SAME_HIGHER, ALL)", |
There was a problem hiding this comment.
do you need to provide version rule ALL, in order the rollback to work?
I guess users will rollback to previous versions?
commands/rollback_mta_command.go
Outdated
| func (c *RollbackMtaCommand) GetPluginCommand() plugin.Command { | ||
| return plugin.Command{ | ||
| Name: "rollback-mta", | ||
| HelpText: "Rollback of a multi-target app", |
There was a problem hiding this comment.
I think we can add more info that it will work only if the user has specified --backup-existing-apps in the previous deploy
There was a problem hiding this comment.
If we do this than should we also add info in the descrption of --backup-existing-apps that if the user wants to rollback they have to use the new command
| // Context("when namespace is provided", func() { | ||
| // It("includes the namespace in the request", func() { | ||
| // flags.String("namespace", "test-namespace", "") | ||
| // fakeServer.AppendHandlers( | ||
| // ghttp.CombineHandlers( | ||
| // ghttp.VerifyRequest("GET", "/mtas/test-mta-id"), | ||
| // ghttp.RespondWith(http.StatusOK, `[]`), | ||
| // ), | ||
| // ghttp.CombineHandlers( | ||
| // ghttp.VerifyRequest("POST", "/mtas/test-mta-id/rollback"), | ||
| // ghttp.RespondWith(http.StatusCreated, nil), |
There was a problem hiding this comment.
why are these tests commented out?
commands/deploy_command.go
Outdated
| applyNamespaceAppRoutesOpt = "apply-namespace-app-routes" | ||
| applyNamespaceAsSuffix = "apply-namespace-as-suffix" | ||
| maxNamespaceSize = 36 | ||
| shouldBackupExistingApps = "backup-existing-apps" |
There was a problem hiding this comment.
I see that there is a pattern the names of the variables to like the parameter name and at the end to habe Opt
commands/rollback_mta_command.go
Outdated
| func (c *RollbackMtaCommand) GetPluginCommand() plugin.Command { | ||
| return plugin.Command{ | ||
| Name: "rollback-mta", | ||
| HelpText: "Rollback of a multi-target app", |
There was a problem hiding this comment.
If we do this than should we also add info in the descrption of --backup-existing-apps that if the user wants to rollback they have to use the new command
theghost5800
force-pushed
the
rollback-feature
branch
from
288cd95 to
10ae38c
Compare
Description:
Issue: