Add SapMachine as alternative JRE #554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds SapMachine as an alternative JRE. See sapmachine.io for more details.
|
Hey reshnm! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
Finally, two great things come together :-) Looking forward to seeing the SapMachine as supported JRE by the Java Buildpack. @nebhale: Let us know if we missed something. |
|
@reshnm Just to confirm; this is a fully compatible fork of OpenJDK? So there's no need for any custom behavior in the buildpack? (To be clear, I'm a big fan of that possibility) |
nebhale
approved these changes
Feb 26, 2018
|
@nebhale Yes, this is a fully compatible fork of OpenJDK and there is no need for any custom behavior in the buildpack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the SapMachine as an alternative JRE for the java-buildpack.
This SapMachine project contains a downstream version of the OpenJDK project. It is used to build and maintain a SAP supported version of OpenJDK for SAP customers who wish to use OpenJDK in their production environments.
Please see sapmachine.io for more details.