Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download tar fix #195

Closed
wants to merge 2 commits into from
Closed

Conversation

cdevarenne
Copy link

In method download_tar the logic to detect if the archive is a gzipped file (tar.gz) adds an 'x' to the tar parameters instead of a 'z'. When executed, the command results into "tar xxf" instead of "tar xzf".

The other thing is that the download_tar method currently does not handle archives with bz2 extensions.

This pull request fixes the issue for gzipped archives and adds support for bz2 files (additional handler added for bz2 files).

@cfdreddbot
Copy link

Hey cdevarenne!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@@ -2,5 +2,6 @@
.idea/workspace.xml
.yardoc
build/
.DS_Store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is platform specific and should live in your personal gitignore $HOME/.gitignore.

@cgfrost
Copy link
Contributor

cgfrost commented Jun 4, 2015

These changes all look good to me, please can you address the one comment about the ignore file and squash/rebase the pull request in to a single commit. There should be no need to close this pull request and open a new one. Just push the changes to your branch and github will do the rest.

fix Rubocop issues
remove local entry for .gitignore
@cdevarenne
Copy link
Author

Thank you Christopher, I did a rebase/squash and the build passed now.
Thank you for your patience.

Claude

On Thu, Jun 4, 2015 at 2:17 AM, Christopher Frost [email protected]
wrote:

These changes all look good to me, please can you address the one comment
about the ignore file and squash/rebase the pull request in to a single
commit. There should be no need to close this pull request and open a new
one. Just push the changes to your branch and github will do the rest.


Reply to this email directly or view it on GitHub
#195 (comment)
.

@nebhale nebhale closed this in 0819957 Jun 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants