-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java 9 compatibility #543
Comments
The memory space output printed after the OOM gives you an indication of the issue:
(Note that the order is a bit screwed up. Updating the latest version of the client, and the latest version of Loggergator/CF sorts this out.) The calculated memory configuration is listed as the first line of output:
So it would appear that the calculator is choosing 38M which is way too small to be functional. I just pushed a simple Spring Boot application against Java 8 and it chose ~100M. That seems to indicate that it's not noticing all of the possible Java 9 classes (guessing that they've moved |
Previously, when counting classes, the buildpack only looked into JAR files for classes that might be loaded. In Java 9, the filenames have changed (while maintaining their "ZIP-ness"), and now have .jmod extensions. This change updates the class count algorithm to examine .jmod files as well. [resolves #543]
Thanks @nebhale I meant to come back & post some more information as I've been debugging this morning on my side. When pushing to PCF if I add |
As expected 😄. I'm working on it now, but this new binary format doesn't seem too examinable. |
do you have to do something special to get the hints printed? |
Hi - as specified in #495 many frameworks don't seem ready for Java 9 yet. I have a very small "Hello World" spring boot app using Spring Boot 2 with Java 9. This app runs fine locally, yet when I push to cloud foundry using build pack 4.7 or higher (I've tried with 4.7, 4.7.1, & 4.8) the application blows up at startup.
When I run locally (compiled & running on Java 9) I see:
The Java 9 warnings are just that - warnings. The Java 9 default is to permit the reflection to happen.
This is what my manifest looks like:
Is there something else I need to do?
Here is the log output during the push:
The text was updated successfully, but these errors were encountered: