Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make syslog logging useable #411

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on Nov 14, 2024

  1. feat: make syslog logging useable

    * do not log an empty new line when writing to syslog
    * allow operator to configure truncation on syslog
    maxmoehl committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    fcdee06 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d162cdc View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. feat: replace log/syslog with internal version

    The go standard library implementation of log/syslog has been abandoned
    and is no longer maintained. In our tests with syslog logging in
    gorouter we noticed a significant performance penalty over file based
    logging. However, with file based logging we frequently observe broken
    logs because logrotate interferes with log reading / writing.
    
    This commit inlines the relevant file from log/syslog and refactors the
    implementation to be on-par with the file based logging.
    
    Co-authored-by: Alexander Lais <[email protected]>
    maxmoehl and peanball committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    2aa3eba View commit details
    Browse the repository at this point in the history