Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check diego port from diego listen address #879

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Conversation

mariash
Copy link
Member

@mariash mariash commented Dec 29, 2023

This change is a follow up fix for #878

We want to validate listen address and not health address when checking bbs port. Health address will always be up no matter if BBS holds the lock or not.

@mariash mariash requested a review from a team as a code owner December 29, 2023 20:06
@dsabeti dsabeti merged commit 4e7b19b into develop Dec 29, 2023
@jrussett jrussett deleted the fix-diego-listen-addr branch January 19, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants