Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stefan Yonkov as contributor #794

Closed
wants to merge 0 commits into from

Conversation

s-yonkov-yonkov
Copy link
Contributor

add s-yonkov-yonkov as contributor

Copy link

@theghost5800 theghost5800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s-yonkov-yonkov is a new team member of multiapps team

@Yavor16
Copy link
Contributor

Yavor16 commented Mar 12, 2024

s-yonkov-yonkov is a new team member of multiapps team

@beyhan beyhan added the wg label Mar 14, 2024
@beyhan
Copy link
Member

beyhan commented Mar 14, 2024

@stephanme this should be ready for merge.

@s-yonkov-yonkov s-yonkov-yonkov changed the title Update contributors.yml Add Stefan Yonkov as contributor Mar 18, 2024
@s-yonkov-yonkov
Copy link
Contributor Author

s-yonkov-yonkov commented Mar 18, 2024

@beyhan @stephanme can someone please check and approve this pull request?

@stephanme
Copy link
Member

According to https://github.com/cloudfoundry/community/blob/main/toc/ROLES.md and rfc-0008-role-change-process the normal promotion process is from contributor over reviewer to approver.
In addition, you should document your contributions (PRs, issues, reviews, contribution to discussion on slack) in this PR so that other approvers and me can judge if you fulfil the requirements for a promotion. There is a helpful contributions-for-user.sh script that lists your contributions.

See e.g. #786 or #710 for good examples.

@beyhan
Copy link
Member

beyhan commented Mar 25, 2024

I have a running setup with contributions-for-user.sh and here are the contributions:

App Runtime Interfaces: MultiApps Contributions

PRs Commented on/Reviewed:

Issues that may be relevant:

Code contributions:

@beyhan
Copy link
Member

beyhan commented Apr 16, 2024

@s-yonkov-yonkov how would like to proceed here.

@s-yonkov-yonkov
Copy link
Contributor Author

I would like to be added as contributor as I am a new team member of multiapps team.

@beyhan
Copy link
Member

beyhan commented Apr 16, 2024

I would suggest to amend then this pr so that only the contributors part stays.

@s-yonkov-yonkov
Copy link
Contributor Author

As far as I can see I'm making the same change as all other colleagues in the multiapps team did. They were added with the same changes applied. Can you please let me know if I should perform any additional steps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants