-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stefan Yonkov as contributor #794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s-yonkov-yonkov is a new team member of multiapps team
s-yonkov-yonkov is a new team member of multiapps team |
@stephanme this should be ready for merge. |
@beyhan @stephanme can someone please check and approve this pull request? |
According to https://github.com/cloudfoundry/community/blob/main/toc/ROLES.md and rfc-0008-role-change-process the normal promotion process is from contributor over reviewer to approver. |
I have a running setup with contributions-for-user.sh and here are the contributions: App Runtime Interfaces: MultiApps ContributionsPRs Commented on/Reviewed:Issues that may be relevant:
Code contributions: |
@s-yonkov-yonkov how would like to proceed here. |
I would like to be added as contributor as I am a new team member of multiapps team. |
I would suggest to amend then this pr so that only the contributors part stays. |
As far as I can see I'm making the same change as all other colleagues in the multiapps team did. They were added with the same changes applied. Can you please let me know if I should perform any additional steps? |
3ea5420
to
e58ad21
Compare
add s-yonkov-yonkov as contributor