Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cf-credhub team membership #371

Closed
wants to merge 1 commit into from
Closed

Update cf-credhub team membership #371

wants to merge 1 commit into from

Conversation

peterhaochen47
Copy link
Member

  • removes past members
  • adds new member Tallicia, who just joined our team

- removes past members
- adds new member `Tallicia`, who just joined our team
Copy link
Member

@stephanme stephanme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Credhub is part of the FI working group. Approvers should be maintained directly in the yaml block of the WG charter (https://github.com/cloudfoundry/community/blob/main/toc/working-groups/foundational-infrastructure.md).
The following github team is generated from the WG charter for Credhub: https://github.com/orgs/cloudfoundry/teams/wg-foundational-infrastructure-credential-management-credhub-approvers
Manually maintained (aka non-standard) github teams will be deleted by #262 .

@emalm emalm requested review from rkoster and beyhan July 26, 2022 14:26
@emalm emalm added the wg label Jul 26, 2022
@peterhaochen47
Copy link
Member Author

peterhaochen47 commented Jul 29, 2022

Credhub is part of the FI working group. Approvers should be maintained directly in the yaml block of the WG charter (https://github.com/cloudfoundry/community/blob/main/toc/working-groups/foundational-infrastructure.md). The following github team is generated from the WG charter for Credhub: https://github.com/orgs/cloudfoundry/teams/wg-foundational-infrastructure-credential-management-credhub-approvers Manually maintained (aka non-standard) github teams will be deleted by #262 .

@stephanme Thank you for the information. This PR is only about adjusting the members section of credhub team, not maintainers / Approvers.

For this PR, I am following this instruction:

A Working Group approver or lead should raise a PR on the community repository to propose adding a new member to the cloudfoundry GitHub org. This PR should add the member directly to the YAML file describing the organization membership, as automation will synchronize the GitHub org membership with the contents of this file periodically.

Is this PR not the right way to "propose adding a new member to the cloudfoundry GitHub org?"

@peterhaochen47 peterhaochen47 requested a review from stephanme July 29, 2022 21:28
@emalm
Copy link
Member

emalm commented Aug 30, 2022

Hey, @peterhaochen47 , now that #262 is accepted as RFC 0013, #387 will remove all the teams that aren't derived from official Working Group and TOC roles, so the change in this PR wouldn't persist for long.

I think what you want to do instead is to follow the process at https://github.com/cloudfoundry/community/blob/main/toc/ROLES.md#promotion-to-contributor to add @Tallicia as a Contributor in the CF org. That process includes getting them them to the separate list of contributors -- the specifics of RFC 0002 are a little out of date, since we extracted the organization member list from the cloudfoundry.yml file into that separate contributors file after it was accepted. As a Contributor, they can then contribute towards becoming a Reviewer and then an Approver in the CredHub area.

@peterhaochen47
Copy link
Member Author

@emalm Makes sense. We will start using the new process. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants